-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename inner field names #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reez
force-pushed
the
issue-366
branch
3 times, most recently
from
August 16, 2023 18:50
ab1bd51
to
7f22631
Compare
I couldn't find where that |
Thanks for the helpful review and guiding on this @notmandatory , I updated the code to reflect the changes requested (CI + tests pass). |
thunderbiscuit
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename non-public inner struct fields as "inner"
Notes to the reviewers
Linked Issue and description
I looked thru the list of items referenced in the Issue that needed to be changed:
The only item from that list I didn't change was
Input._inner
because I couldn't findInput
. I tried to do some digging to see ifInput
was changed to something else but I didn't quite find it.I did not make any changes to the
bdk.udl
fileLet me know if there is anything that should/shouldn't be changed that I missed.
Also if this gets approved I'm totally happy to wait on it being merged if #392 needs to be merged first or anything.
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: