Add is_valid_for_network to address #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
ACK fc25cd7. Yeah lots of tests haha. But I'm not against them!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves Expose Address::is_valid_for_network Issue.
Notes to the reviewers
I decided to be super exhaustive about the unit tests for clarity on what
is_valid_for_networkwould return in each scenario. I'm planning on cutting down and/or re-formatting those but would like some feedback on what you would like to see stay/go/change. Tests were written for Rust, as well as for all 4 supported platforms.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: