Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bdk to alpha 8 #482

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Apr 1, 2024

This PR upgrades bdk to alpha 8 as well as bdk_esplora to 0.10.0 and bdk_file_store to 0.8.0.

It required the FeeRate object to be fiddled with a little bit because bdk now uses the bitcoin::FeeRate, which uses u64s instead of f32 in most places. The names of the methods are also changed a little bit, and the from_sat_per_vb constructor actually returns None when the input produces an arithmetic overflow. I decided to return an error instead, to keep the struct simple (having a None in there would require the FeeRate object to be different in nature than what we currently have, and I think an error is appropriate in this case anyway). Happy to hear questions/thoughts on this, because it's a slight deviation from the Rust API.

Merge after 471, 479, 480 and 481.

Copy link

coderabbitai bot commented Apr 1, 2024

Warning

Rate Limit Exceeded

@thunderbiscuit has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 17 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between e774c94 and aa03558.

Walkthrough

The updates focus on modernizing the development environment by upgrading to newer versions of Java, Kotlin, and Gradle, incorporating Rust, and refining fee rate calculations. Standardized commands using justfile across different modules streamline development processes for testing, building, and publishing.

Changes

Files Change Summary
.github/workflows/...yaml Updated Java version to 17, default Rust version to 1.73.0, and added support for Python 3.11 and 3.12.
bdk-android/README.md, bdk-jvm/README.md Updated required Kotlin version to 1.9.23 and JDK version to 17 for bdk-jvm.
bdk-android/build.gradle.kts, bdk-jvm/build.gradle.kts, bdk-android/lib/build.gradle.kts, bdk-jvm/lib/build.gradle.kts Updated plugin versions and configurations, adjusted plugin IDs, repository declarations, Android settings, and Gradle distribution URL.
bdk-android/justfile, bdk-jvm/justfile, bdk-ffi/justfile, bdk-python/justfile, bdk-swift/justfile Introduced justfile for standardized commands in testing, building, and publishing.
bdk-android/settings.gradle.kts, bdk-jvm/settings.gradle.kts Added plugin and dependency repositories configurations for project setup and management.
bdk-ffi/src/... Various updates related to FeeRate and BumpFeeTxBuilder for improved precision and functionality.
bdk-jvm/gradlew, bdk-jvm/gradlew.bat Modified script generation for improved execution and error handling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thunderbiscuit thunderbiscuit force-pushed the alpha8 branch 2 times, most recently from 148adf6 to fb169f0 Compare April 4, 2024 14:57
bdk-jvm/README.md Outdated Show resolved Hide resolved
bdk-android/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aa03558

@thunderbiscuit thunderbiscuit merged commit aa03558 into bitcoindevkit:master Apr 5, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants