-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bdk to alpha 8 #482
Bump bdk to alpha 8 #482
Conversation
Warning Rate Limit Exceeded@thunderbiscuit has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 17 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates focus on modernizing the development environment by upgrading to newer versions of Java, Kotlin, and Gradle, incorporating Rust, and refining fee rate calculations. Standardized commands using Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
148adf6
to
fb169f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK aa03558
This PR upgrades bdk to alpha 8 as well as bdk_esplora to 0.10.0 and bdk_file_store to 0.8.0.
It required the FeeRate object to be fiddled with a little bit because bdk now uses the bitcoin::FeeRate, which uses u64s instead of f32 in most places. The names of the methods are also changed a little bit, and the
from_sat_per_vb
constructor actually returns None when the input produces an arithmetic overflow. I decided to return an error instead, to keep the struct simple (having a None in there would require the FeeRate object to be different in nature than what we currently have, and I think an error is appropriate in this case anyway). Happy to hear questions/thoughts on this, because it's a slight deviation from the Rust API.Merge after 471, 479, 480 and 481.