Remove bdk-jvm and bdk-android examples from readmes #489
Conversation
WalkthroughThe recent updates involve removing example code snippets from the README.md files of both Changes
Assessment against linked issues
The changes directly address the objective stated in issue #476 by removing the specified example code from the README.md files of both Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Actionable comments outside the diff hunks (16)
bdk-jvm/README.md (8)
Line range hint
1-1: Ensure a blank line is added after the heading for proper markdown formatting.1a2 +
Line range hint
4-4: Ensure a blank line is added after the heading for proper markdown formatting.4a5 +
Line range hint
28-28: Ensure a blank line is added after the heading for proper markdown formatting.28a29 +
Line range hint
31-31: Ensure a blank line is added after the heading for proper markdown formatting.31a32 +
Line range hint
57-57: Ensure a blank line is added after the heading for proper markdown formatting.57a58 +
Line range hint
74-74: Ensure a blank line is added after the heading for proper markdown formatting.74a75 +
Line range hint
75-75: Ensure a blank line is added both above and below the heading for proper markdown formatting.74a75 + 76a78 +
Line range hint
76-76: Remove trailing spaces to clean up the markdown file.- Depending on the JVM version you use, you might not have the JNA dependency on your classpath. The exception thrown will be + Depending on the JVM version you use, you might not have the JNA dependency on your classpath. The exception thrown will bebdk-android/README.md (8)
Line range hint
1-1: Ensure a blank line is added after the heading for proper markdown formatting.1a2 +
Line range hint
4-4: Ensure a blank line is added after the heading for proper markdown formatting.4a5 +
Line range hint
28-28: Ensure a blank line is added after the heading for proper markdown formatting.28a29 +
Line range hint
33-33: Ensure a blank line is added after the heading for proper markdown formatting.33a34 +
Line range hint
68-68: Ensure a blank line is added after the heading for proper markdown formatting.68a69 +
Line range hint
85-85: Ensure a blank line is added after the heading for proper markdown formatting.85a86 +
Line range hint
86-86: Ensure a blank line is added both above and below the heading for proper markdown formatting.85a86 + 87a89 +
Line range hint
40-40: Remove trailing spaces to clean up the markdown file.- Depending on the JVM version you use, you might not have the JNA dependency on your classpath. The exception thrown will be + Depending on the JVM version you use, you might not have the JNA dependency on your classpath. The exception thrown will be
|
|
||
| val newAddress = wallet.getAddress(AddressIndex.LastUnused) | ||
| ``` | ||
|
|
||
| ### Snapshot releases |
There was a problem hiding this comment.
Ensure a blank line is added after the heading for proper markdown formatting.
16a17
+Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ### Snapshot releases | |
| ### Snapshot releases | |
|
|
||
| val newAddress = wallet.getAddress(AddressIndex.LastUnused) | ||
| ``` | ||
|
|
||
| ### Snapshot releases |
There was a problem hiding this comment.
Ensure a blank line is added after the heading for proper markdown formatting.
16a17
+Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ### Snapshot releases | |
| ### Snapshot releases | |
This PR fixes #476.