Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back TxIn and methods on Transaction #536

Merged
merged 3 commits into from
May 16, 2024

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented May 16, 2024

This PR add the TxIn type from rust bitcoin, and adds the Transaction.input(), Transaction.output(), and Transaction.lock_time() methods.

Description

The input() and output() methods are actually just returning the actual field on the type, hence their name. I don't know why those fields are not called inputs and outputs, but I didn't want to clean up rust-bitcoin's naming convention.

Notes to the reviewers

The LockTime field is a really good one to add in the future, and we should open an issue for it (returning a LockTime instead of a u32).

Changelog notice

Added
  - TxIn type [#536]
  - Transaction.input() method [#536]
  - Transaction.output() method [#536]
  - Transaction.lock_time method [#536]

[#536]: https://github.com/bitcoindevkit/bdk-ffi/pull/536

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit thunderbiscuit requested a review from reez May 16, 2024 19:04
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5e3e249

Nice!

@thunderbiscuit thunderbiscuit merged commit 5e3e249 into bitcoindevkit:master May 16, 2024
25 checks passed
@thunderbiscuit thunderbiscuit deleted the feature/txin branch May 16, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants