-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bdk_wallet to alpha 12 #544
Update bdk_wallet to alpha 12 #544
Conversation
8fb3f3f
to
0a0aa10
Compare
This commit also introduces the sqlite store and removes the flat file store
0a0aa10
to
19b4e11
Compare
b78dd95
to
ea0f0ab
Compare
ea0f0ab
to
65702f4
Compare
@@ -296,7 +296,7 @@ impl TxBuilder { | |||
}) | |||
} | |||
|
|||
pub(crate) fn fee_absolute(&self, fee_amount: u64) -> Arc<Self> { | |||
pub(crate) fn fee_absolute(&self, fee_amount: Arc<Amount>) -> Arc<Self> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the new Amount
type here and other places, v cool
@@ -606,7 +618,7 @@ pub enum TxidParseError { | |||
InvalidTxid { txid: String }, | |||
} | |||
|
|||
// This error combines the Rust bdk::wallet::NewOrLoadError and bdk_file_store::FileError | |||
// This error combines the Rust bdk::wallet::NewOrLoadError and bdk_wallet::rusqlite::Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for even remembering to update these spots, you're on it!
fn from( | ||
tx: BdkCanonicalTx<'_, Arc<bdk::bitcoin::Transaction>, ConfirmationTimeHeightAnchor>, | ||
) -> Self { | ||
impl From<BdkCanonicalTx<'_, Arc<BdkTransaction>, ConfirmationTimeHeightAnchor>> for CanonicalTx { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing things like this in this PR so we can have things like Arc<BdkTransaction>
instead of Arc<bdk::bitcoin::Transaction>
, makes it clean and I need to make sure I'm paying attention to this sort of stuff to for any of my new PR's
ACK 65702f4 Really good job! for :
...I'm good with either decision. In testing on the iOS app i did happen to run into the variant on the I tested the bindings by building them locally and then using them on the BDK iOS app, and made some slight adjustments to make it transition smoothly on the iOS client just in case anyone is interested in taking a peek at that: bitcoindevkit/BDKSwiftExampleWallet#146 |
This PR upgrades the (newly named!) bdk_wallet library to the alpha 12 version.
Also part of this are the upgrade to bdk_esplora (0.14.0), bdk_electrum (0.14.0), and the introduction of the new bdk_sqlite (0.1.0) persistence crate.
Note:
bdk
are now switched tobdk_wallet
..sqlite
, as is common for those types of files (but is not required). This is also the naming used on the Rust bdk side, so I think it's a good fit anyway.Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing