Use external uniffi library for rust-bitcoin types #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
4 times, most recently
from
fb7d9d8 to
30cf4af
Compare
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
5 times, most recently
from
e5f0925 to
eaab4fe
Compare
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
2 times, most recently
from
3d23579 to
6a9df3d
Compare
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
2 times, most recently
from
00e03c1 to
b06cb6b
Compare
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
8 times, most recently
from
491b3a4 to
ee195fb
Compare
|
This is so so great. Compiled and ran this PR's Swift bindings locally and used in Example Wallet and everything built and ran in the iOS app ✅ You may already be planning on it, but would love to see this squash down to one commit when merged since that will be nice historically to go back to see what all had to be changed to use the external ACK ee195fb |
reez
approved these changes
Aug 30, 2024
|
Ah yes good point, I think a squash makes sense. |
thunderbiscuit
force-pushed
the
feature/rust-bitcoin
branch
from
ee195fb to
e23398f
Compare
|
I have run all live tests locally for all four libraries. In addition, here is the CI workflow for the live tests: https://github.com/bitcoindevkit/bdk-ffi/actions/runs/10636432218. If all passes in both CIs I'll merge later on today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows our library to depend on an external bitcoin-ffi library. This is useful because it means we can collaborate with other projects who also need to use types from rust-bitcoin in their uniffi bindings.
I propose we merge some types coming from bitcoin-ffi for the beta 2 release as a good way to introduce the design and workflow slowly but surely. All libraries build and work well locally and pass CI.
Closes #556.