Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display trait to mnemonic #558

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add display trait to mnemonic #558

merged 1 commit into from
Jun 13, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Jun 13, 2024

Description

Adds more to #551 , I was working on BDK iOS and just saw that I was using Mnemonic.asString() so I wanted to make that nicer by using the display trait on Mnemonic instead now after seeing #551 .

This also removes the asString() method which is nice.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez marked this pull request as ready for review June 13, 2024 01:36
@reez reez requested a review from thunderbiscuit June 13, 2024 01:37
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 94d31ff. Awesome to see how easy it is to convert our current structs to the new way of doing it.

@reez reez self-assigned this Jun 13, 2024
@reez reez merged commit 94d31ff into bitcoindevkit:master Jun 13, 2024
25 checks passed
@reez reez deleted the mnemonic branch June 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants