Bump minimum supported Android version to 24 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
feature/android-24
branch
from
b8ff12f to
a2794f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our minimum supported Android version to 24. The lowest version I was able to find a user of bdk supporting was 24 (a very conservative choice, see here. 21 at this point was a bit ludicrous, and will probably not be available in future NDKs, which we will have to update at some point for CI and just overall health of the Android libs. I think this gets ahead of those issues while being extremely conservative (API level 24 came out in 2016).
I have tested this locally on emulators and in the example application.
Fixes #500.
Note: I'm sorry this PR actually contains a second commit which fixes the live tests (I noticed the failure and fixed it without realizing it was on this branch). But now it's here I'm just going to leave it here anyway. It's a good fix that was missed as part of the Display trait PRs because it's part of the live tests that don't get run on all normal PR CI runs.