Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up import paths that use blockdata #568

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Clean up import paths that use blockdata #568

merged 1 commit into from
Jul 2, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Jul 1, 2024 •
edited
Loading

Description

In rust-bitcoin the blockdata module is a code organisation thing, it should never have been public.

These were the spots I saw blockdata:: being used, so I updated the import paths.

Thanks for adding an Issue for this Thunder-

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez self-assigned this Jul 1, 2024
@reez reez linked an issue Jul 1, 2024 that may be closed by this pull request
Clean up import paths that use blockdata:: #565
Closed
@reez reez requested a review from thunderbiscuit July 1, 2024 18:20
thunderbiscuit
thunderbiscuit approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3454331.

@thunderbiscuit thunderbiscuit merged commit 3454331 into bitcoindevkit:master Jul 2, 2024
25 checks passed
@reez reez deleted the blockdata branch July 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees

@reez reez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up import paths that use blockdata::
2 participants
@reez @thunderbiscuit