Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shell scripts to build bdk-jvm and bdk-android #584

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Aug 16, 2024

This PR removes the Gradle plugins form the JVM and Android libraries and replaces them with simpler to read, simpler to maintain shell scripts.

TODO

  • Fix test CI workflow (JVM)
  • Fix publishing CI workflow (JVM)
  • Fix justfile (JVM)
  • Fix live tests workflow
  • Fix test CI workflow (Android)
  • Fix publishing CI workflow (Android)
  • Fix justfile (Android)

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@thunderbiscuit
Copy link
Member Author

FYI the Windows script is totally wrong and needs fixing! The library that we output is bdkffi instead of libbdkffi.

@thunderbiscuit thunderbiscuit force-pushed the feature/jvm-scripts branch 7 times, most recently from 9e7e97f to b00fa92 Compare September 27, 2024 15:04
@thunderbiscuit thunderbiscuit requested a review from reez September 27, 2024 16:09
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b00fa92

@thunderbiscuit thunderbiscuit mentioned this pull request Sep 27, 2024
8 tasks
@thunderbiscuit thunderbiscuit merged commit d4178f6 into bitcoindevkit:master Sep 27, 2024
2 checks passed
@thunderbiscuit thunderbiscuit deleted the feature/jvm-scripts branch September 27, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants