-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump bdk to beta_5 #600
Conversation
874a522
to
280eecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice cleanup.
I have one tiny thing I'd like to clean up before merging, but that's it.
Nice work; I like the removal of the explicit rbf setter, and we're probably the first ones to do that by default!
bdk-ffi/Cargo.toml
Outdated
bdk_esplora = { version = "0.18.0", default-features = false, features = ["std", "blocking", "blocking-https-rustls"] } | ||
bdk_electrum = { version = "0.18.0", default-features = false, features = ["use-rustls-ring"] } | ||
bdk_bitcoind_rpc = { version = "0.15.0" } | ||
bdk_wallet = { version = "1.0.0-beta.5", features = ["all-keys", "keys-bip39", "rusqlite"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I think we should pin the bdk_wallet dependency to beta 5. The default cargo behaviour of updating to the latest patch broke my (and all of our) builds as of yesterday when they released beta 5 which contained a breaking change. This is not a bdk problem but really a cargo problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed an update to pin, but just double check its what you were asking for and I won't merge or anything until you give it the go ahead that this is good-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I chose "Approve" when I should have clicked "Request changes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6cfcf23. Ready to merge.
Description
This pull request updates the bdk-ffi crate to use the latest beta version of bdk, specifically version 1.0.0-beta.5.
The main changes include:
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: