Remove dependency on bdk_bitcoind_rpc #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
refactor/remove-dependency
branch
from
8ae3a88 to
cecca3d
Compare
thunderbiscuit
force-pushed
the
refactor/remove-dependency
branch
from
cecca3d to
3cc3365
Compare
reez
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one had been nagging at me for a while. We were using bdk_bitcoincore_rpc as a way to get to some types that are part of rust-bitcoin. No need to depend on bdk_bitcoincore_rpc until we add the RPC client.
Changelog notice
No changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing