Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump snapshot and dev versions of libraries #609

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Bump snapshot and dev versions of libraries #609

merged 4 commits into from
Oct 17, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Oct 16, 2024 •
edited
Loading

Description

Step 31 in Issue for beta 5 release.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez changed the title Beta5 release (draft) Beta5 release Oct 17, 2024
@reez reez marked this pull request as ready for review October 17, 2024 01:19
@reez reez requested a review from thunderbiscuit October 17, 2024 01:21
@reez
Copy link
Collaborator Author

reez commented Oct 17, 2024

@thunderbiscuit I can also update this line to say something different since I'm not sure we have those two templates anymore (maybe replace with release)?

@reez reez changed the title (draft) Beta5 release Beta5 release Oct 17, 2024
@reez reez changed the title Beta5 release Bump snapshot and dev versions of libraries Oct 17, 2024
@reez reez changed the title Bump snapshot and dev versions of libraries Bump snapshot and dev versions of libraries (1.0.0-beta.5) Oct 17, 2024
@reez reez changed the title Bump snapshot and dev versions of libraries (1.0.0-beta.5) Bump snapshot and dev versions of libraries Oct 17, 2024
thunderbiscuit
thunderbiscuit requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small changes required on the release issue template but otherwise this looks great. I also think you might need a rebase on master.

.github/ISSUE_TEMPLATE/release.md Outdated
@@ -89,7 +89,7 @@ git push upstream v0.6.0
28. - [ ] Aggregate all the changelog notices from the PRs and add them to the changelog file
29. - [ ] Bump the versions on master from `0.9.0-SNAPSHOT` to `0.10.0-SNAPSHOT`, `0.6.0.dev0` to `0.7.0.dev0`
30. - [ ] Apply changes to the minor_release and patch_release issue templates if they need any
31. - [ ] Open a PR on master with the changes in steps 29, 30, and 31. See [example PR here](https://github.com/bitcoindevkit/bdk-ffi/pull/317). Get a review and merge the PR.
31. - [ ] Open a PR on master with the changes in steps 28, 29, 30, and 31. See [example PR here](https://github.com/bitcoindevkit/bdk-ffi/pull/317). Get a review and merge the PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving 31 here is sort of self-referencing. I suggest to only keep 28, 29, 30.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed 31, then just re-numbered the steps that followed-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Yep I re-read what I wrote and I see how it sounded now. Yeah that works too!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fairly clear those changes need to be merged. As long as it's clear to you as well that they need to be merged on master then it's cool.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think its clear to me now but I'll keep it in mind, but yeah I read it one way at first and updated the PR and re-read it now and it makes sense in a different way. Will merge this PR, but will keep in mind if it doesnt make sense next time to add it back or re-word it

.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
@reez
Copy link
Collaborator Author

reez commented Oct 17, 2024

Super small changes required on the release issue template but otherwise this looks great. I also think you might need a rebase on master.

Changes made & rebased-

thunderbiscuit
thunderbiscuit approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ed2aadf.

@reez reez merged commit ed2aadf into bitcoindevkit:master Oct 17, 2024
22 checks passed
@reez reez deleted the beta5-release branch October 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @thunderbiscuit