Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename is_coin_base to is_coinbase #1191

Closed
Tracked by #86
, #87
...
realeinherjar opened this issue Nov 1, 2023 · 3 comments
Closed
Tracked by #86
, #87
...

Rename is_coin_base to is_coinbase #1191

realeinherjar opened this issue Nov 1, 2023 · 3 comments
Labels
api A breaking API change module-wallet

Comments

@realeinherjar
Copy link
Contributor

rust-bitcoin v0.31.1 has deprecated is_coin_base and renamed to is_coinbase in rust-bitcoin/rust-bitcoin#1796.

The functionality seems the same.

We are using the deprecated one in

bdk/crates/chain/src/tx_graph.rs

Lines 260 to 262 in 3569acc

if tx.is_coin_base() {
return Ok(0);
}

bdk/crates/bdk/src/wallet/mod.rs

Line 1695 in 3569acc

if tx.is_coin_base() {

@realeinherjar realeinherjar added the bug Something isn't working label Nov 1, 2023
@realeinherjar realeinherjar mentioned this issue Nov 1, 2023
Merged
@nondiremanuel nondiremanuel mentioned this issue Nov 5, 2023
Closed
38 tasks
@notmandatory notmandatory added this to BDK Nov 13, 2023
@notmandatory notmandatory moved this to Todo in BDK Nov 13, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Nov 13, 2023
@notmandatory
Copy link
Member

Good suggestion!

@nondiremanuel nondiremanuel mentioned this issue Nov 19, 2023
Closed
54 tasks
@nondiremanuel nondiremanuel mentioned this issue Dec 2, 2023
Closed
55 tasks
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@nondiremanuel nondiremanuel removed the bug Something isn't working label Jan 25, 2024
@notmandatory notmandatory added module-wallet api A breaking API change labels Mar 18, 2024
@notmandatory notmandatory mentioned this issue Mar 18, 2024
Closed
@notmandatory
Copy link
Member

A small change but I think we should push to 2.0 milestone.

@nondiremanuel nondiremanuel removed this from the 1.0.0-alpha milestone Mar 21, 2024
@ValuedMammal
Copy link
Contributor

Done in #1177

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api A breaking API change module-wallet
Projects
BDK
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@notmandatory @nondiremanuel @ValuedMammal @realeinherjar