W47 Lib Team Call

[nondiremanuel]

📆 Mon November 8, 2023 19:00 UTC
📍 Discord General Voice Channel

Please add comments to this issue to suggest issues and PRs to discuss.

General Discussion Items

• BDK 1.0 milestones and timeline: added an alpha.4 milestone to separate the work -> we will try with deadlines every two week
• BDK Review Club: no review scheduled
• Any review begs? 🙏
• Blockers? 🪨 Please don't stabilize this crate just yet bdk#1215: to be discussed with rust-bitcoin team (Kixunil) -> fine for now

Top BDK 1.0 PRs and issues

alpha.3

Recently merged:

• LocalChain with hardwired genesis block bdk#1178
• Add CreateTxError and use as error type for TxBuilder::finish() bdk#1028
• Further improve unconfirmed tx conflict resolution bdk#1109
• fix(electrum): fixed chain sync issue bdk#1145
• fix(chain): filter coinbase tx not in best chain bdk#1202
• fix(bdk): Check if we're using the correct internal key before signing bdk#1200

Need Review:

• Add Wallet::list_output method bdk#1190: review ongoing -> docs to be improved (different PR), needs a small rebase and then ready to go
• rename scan to scan_with_keychain bdk#1117: should we close this (substituted by Add wallet sync_request and full_scan_request functions bdk#1194)? -> still not included in any other PR, we keep it open for the moment, moved to alpha.4
• ref(hwi): Move hwi out of bdk bdk#1161: waiting to be reviewed -> not very high priority, but there are some comments that could need further discussion. If so we can move it to alpha.4
• Include the descriptor in keychain::Changeset bdk#1203: review (and rebasing) ongoing -> needs more discussion, but being pretty important we can leave it to alpha.3
• Introduce block-by-block API to bdk::Wallet and add RPC wallet example bdk#1172: review ongoing
• doc(bdk): Clarify the absolute_fee docs bdk#1158: needs review (it should be a quick one) -> needs rebase?
• doc: Improve TxGraph & co docs bdk#1188: improvement on docs -> one comment left
• chore: remove bdk dependency on log and dev dependency on env_logger bdk#1204: new PR -> waiting to be merged
• esplora: fix incorrect gap limit check in blocking client bdk#1225: new PR

alpha.4

Need Review:

• Clean up clippy allows bdk#1186: fixes #1127, some changes were made after a first review
• Bump MSRV to 1.63.0 bdk#1183: needs to wait LDK's Bump MSRV to rustc 1.63.0 lightningdevkit/rust-lightning#2681 before merging, it will be moved back to draft. Is this still in progress?
• Get keychain for script bdk#1201
• Migrate to bitcoin::FeeRate bdk#1216

In Progress

• Implement default index_tx method bdk#1176: seems to impact the API
• The Wallet.is_mine() function should return K bdk#1042: WIP; code already implemented. For now using KeychainKind
• fix: remove deprecated max_satisfaction_weight bdk#1115: No update. Still on hold, needs some comment from evan and/or Lloyd. The old method has some problems but it's not clear the impact of it. Degree of complexity (and consequently milestone) needs to be discussed
• feat: add bdk_sqlite crate implementing PersistBackend bdk#1128: No update. Another approach has to be tried
• Migrate to bitcoin::FeeRate bdk#1216: substitutes #1141
• Add wallet sync_request and full_scan_request functions bdk#1194: super issue on sync/scan -> only for esplora rn. Will need different PRs?
• Remove TxGraph::missing_heights as ChangeSet::missing_heights_from should have replaced it bdk#1126: discussion ongoing
• Move Balance out of keychain bdk#1175: discussion ongoing
• Introduce new bdk_coin_select implementation bdk#1072: separate repo

To Do:

• Rename electrum's sync/scan bdk#1154: should we close this since there is already Syncing/Rescanning super issue bdk#1195?
• Reintroduce a way verify a transaction bdk#1180: it shouldn't be very hard and lower priority for alpha.4
• build(esplora): Add async-https-rustls flag to esplora client bdk#1179: useful for android binding, possibly to be included in the next bdk_esplora release. Since it should be quick adding a flag, we added to alpha.4 -> will rebase today and merge into alpha.3
• Rename is_coin_base to is_coinbase bdk#1191
• bdk + esplora update_local_chain logic might be off  bdk#1199: bug on esplora update local chain
• Do not include satisfaction in policy id calculation bdk#1218
• refactor(bdk): use idiomatic naming for all getter methods bdk#1221
• [chain] Consider Merging IndexedTxGraph and TxGraph into one thing bdk#1147
• Upgrade to rust-bitcoin 0.31.0 bdk#1196: on the upgrade of rust-bitcoin
• misleading spendable balance bdk#797: API breaking
• Introduce bdk_core crate bdk#1155
• Remove ComputeSighash bdk#1038
• Calling example_electrum sync on an unconfirmed tx may result in the tx being stuck as unconfirmed eternally (according to the cli)) bdk#1125

###Milestone TBD

• Wallet's persistence should have a fixed "header" section bdk#1193: it could be required for alpha.3 since it could have breaking changes
• Backwards compatibility of bdk::ChangeSet data structure bdk#1103: for now alpha.4, to be discussed -> needs discussion to understand if it's a good idea and how breaking it is going to be
• BIP 326 Anti Fee Sniping bdk#1134: for now alpha.4, to be discussed -> needs to be analyzed and see if it breaks the API or not (if not we can defer it)
• Add sign_psbt_input bdk#1219: in 1.1? -> same as 1134

Other updates for future releases

• fix: more typos bdk#1223: ready to merge and blocks #1165
• ci: move to Nix bdk#1165: ci to Nix; possibly in the future also for the ffi repo. Put in beta, if it comes earlier we can include it in alpha
• chore: extract TestEnv into separate crate bdk#1171: in beta, if it comes earlier we can include it in alpha -> added to alpha.4
• fix: clippy warnings bdk#1214: ready or needs rebase?

New Projects and Support

Upcoming Events

• Africa Bitcoin Conference (Accra) Dec 1-3 2023

🌅 Future Call Notes

📜 Past Call Notes