Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdk + esplora update_local_chain logic might be off #1199

Closed
danielabrozzoni opened this issue Nov 8, 2023 · 3 comments · Fixed by #1267
Closed

bdk + esplora update_local_chain logic might be off #1199

danielabrozzoni opened this issue Nov 8, 2023 · 3 comments · Fixed by #1267
Assignees
@evanlinjin
Labels
bug Something isn't working
Milestone
1.0.0-alpha

Comments

@danielabrozzoni
Copy link
Member

See the discussion in #1151: #1151 (comment) (and following comments)
@danielabrozzoni danielabrozzoni added the bug Something isn't working label Nov 8, 2023
@danielabrozzoni danielabrozzoni mentioned this issue Nov 8, 2023
Closed
@notmandatory notmandatory added this to BDK Nov 8, 2023
@notmandatory notmandatory moved this to Todo in BDK Nov 8, 2023
@evanlinjin
Copy link
Member

@LagginTimes didn't you have a WIP progress PR to fix this? I remember we just needed to update the tests to "prove" the fix (which is waiting on the TestEnv.

@LagginTimes
Copy link
Contributor

The PR #1145 fixed an electrum issue which seems to be unrelated to the esplora problem described here.

@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Nov 17, 2023
@nondiremanuel nondiremanuel mentioned this issue Nov 19, 2023
Closed
54 tasks
@nondiremanuel nondiremanuel mentioned this issue Dec 2, 2023
Closed
55 tasks
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@evanlinjin evanlinjin self-assigned this Jan 11, 2024
@evanlinjin
Copy link
Member

I'm looking into this now!

@evanlinjin evanlinjin mentioned this issue Jan 11, 2024
Merged
4 tasks
@nondiremanuel nondiremanuel moved this from Todo to Needs Review in BDK Jan 12, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanlinjin evanlinjin

Labels
bug Something isn't working
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

Simplify Esplora::update_local_chain and add tests evanlinjin/bdk
5 participants
@notmandatory @evanlinjin @danielabrozzoni @nondiremanuel @LagginTimes