-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(bdk): Clarify the absolute_fee docs #1158
Merged
notmandatory
merged 1 commit into
bitcoindevkit:master
from
danielabrozzoni:doc/absolute_fee
Dec 5, 2023
Merged
doc(bdk): Clarify the absolute_fee docs #1158
notmandatory
merged 1 commit into
bitcoindevkit:master
from
danielabrozzoni:doc/absolute_fee
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielabrozzoni
force-pushed
the
doc/absolute_fee
branch
2 times, most recently
from
October 10, 2023 15:18
f40a0c0
to
28f8aff
Compare
danielabrozzoni
force-pushed
the
doc/absolute_fee
branch
from
October 11, 2023 09:44
28f8aff
to
4bb8431
Compare
33 tasks
38 tasks
kaiwolfram
reviewed
Nov 7, 2023
danielabrozzoni
force-pushed
the
doc/absolute_fee
branch
from
November 8, 2023 17:28
4bb8431
to
2e3e630
Compare
evanlinjin
reviewed
Nov 8, 2023
danielabrozzoni
force-pushed
the
doc/absolute_fee
branch
from
November 9, 2023 08:01
2e3e630
to
0ecc028
Compare
54 tasks
55 tasks
notmandatory
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0ecc028
New docs makes sense to me.
5 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1066
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing