fix(chain): filter coinbase tx not in best chain #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The code looks good to me.
In #1144, @evanlinjin says:
A proper test has not been written for this scenario. The test would mine blocks which has the coinbase send to a tracked/owned spk. A reorg should not result in an unconfirmed balance.
Are we ok with the test that this PR includes, or better to also add the one evan is suggesting?
Coinbase transactions cannot exist in the mempool and be unconfirmed. `TxGraph::try_get_chain_position` should always return `None` for coinbase transactions not anchored in best chain.
LagginTimes
force-pushed
the
coinbase_unconfirmed
branch
from
0504151 to
991cb77
Compare
notmandatory
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
ACK 991cb77
I verified new test fails without this fix. If an additional test is needed and not easy to do with current framework can we make a new issue and put in the beta milestone?
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1144.
Coinbase transactions cannot exist in the mempool and be unconfirmed.
TxGraph::try_get_chain_positionshould always returnNonefor coinbase transactions not anchored in best chain.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: