-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coinbase transaction that is not anchored in the best chain should always be filtered out #1144
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Coinbase transactions cannot exist in the mempool and be unconfirmed.
TxGraph::try_get_chain_position
should always returnNone
for coinbase transactions which are not anchored in the best chain.To Reproduce
A proper test has not been written for this scenario. The test would mine blocks which has the coinbase send to a tracked/owned spk. A reorg should not result in an unconfirmed balance.
Expected behavior
Coinbase transactions cannot be "unconfirmed".
The text was updated successfully, but these errors were encountered: