-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add absolute fee and fee rate sanity check in the Wallet API #1231
Labels
Comments
notmandatory
added
new feature
New feature or request
discussion
There's still a discussion ongoing
labels
Nov 28, 2023
55 tasks
Assigned to 1.1 for the moment (during Lib Team Call) |
Another creative approach would be to warn if the fee exceeds a fixed % of the total send amount |
It seems rust-bitcoin added something along these lines in their latest release.
…-------- Original Message --------
On Jan 7, 2024, 8:42 PM, ValuedMammal wrote:
Another creative approach would be to warn if the fee exceeds a fixed % of the total send amount
—
Reply to this email directly, [view it on GitHub](#1231 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F4FMP63LDZFRMOYP6DYNL3CLAVCNFSM6AAAAAA76LHXGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGE2TENBRHE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the enhancement
A BDK wallet should check the absolute transaction fee and free rate when creating, and/or signing a transaction PSBT. There should also be a way to change or disable this fee rate check. I suggest we should make the maximum absolute fee the same as bitcoin core (0.1 BTC), and fee rate the same as what Liana chose (1_000 sats/vb), but defaults are open for discussion.
Use case
This would prevent BDK users from accidentally creating and signing transactions with very large, unreasonable transaction fees. This feature would improve our feature parity with the bitcoin core wallet.
Additional context
Discord comment from @darosior:
For what it's worth in Liana we have both an absolute fee (1BTC) and feerate (1_000 sat/vb) sanity checks: https://github.com/wizardsardine/liana/blob/7bfc53890aa1466b0fee413d7373cbd05fd22a19/src/commands/mod.rs#L213-L238. Bitcoin Core has a 0.1BTC maximum absolute fee sanity check iirc, but you can tweak it. I agree BDK should have one. Any wallet software intended to be used with real funds should have such sanity checks.
The text was updated successfully, but these errors were encountered: