Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxOdering::Shuffle is not shuffling the inputs #865

Closed
Tracked by #46 ...
LLFourn opened this issue Feb 14, 2023 · 3 comments
Closed
Tracked by #46 ...

TxOdering::Shuffle is not shuffling the inputs #865

LLFourn opened this issue Feb 14, 2023 · 3 comments
Assignees
Labels
bug Something isn't working module-wallet

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Feb 14, 2023

TxOdering::Shuffle is not shuffling the inputs (only the outputs).

Bug found while doing bdk core integration. I think it's moderately serious so I think this fix should be backported.

@LLFourn LLFourn added the bug Something isn't working label Feb 14, 2023
@nassersaazi
Copy link

nassersaazi commented Feb 28, 2023

i would love to work on this! it would be my first time contributing to the project, so some context around the issue is highly appreciated

@notmandatory
Copy link
Member

Hi @nassersaazi thanks! but I didn't see your note and I just created #876 . Please feel free to review that PR, but it's very simple, the only interesting thing is to see if you can think of any other test cases or any reason why the tx inputs shouldn't be shuffled when we shuffle the outputs.

@notmandatory
Copy link
Member

Fixed by @LLFourn with 5985706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module-wallet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants