Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TxOrdering::Shuffle to also shuffle the inputs #876

Closed

Conversation

notmandatory
Copy link
Member

Description

Fixes #865

This is a small change to make it so that TxOrdering:Shuffle also shuffles the inputs.

Notes to the reviewers

It looks like input shuffling was meant to be excluded in #38 when the TxOrdering::Shuffle option was added since the corresponding test check that inputs are not shuffled.

Changelog notice

Fixed

  • The TxOrdering::Shuffle option in the TxBuilder now also shuffles the inputs.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory added the bug Something isn't working label Feb 28, 2023
@notmandatory notmandatory self-assigned this Feb 28, 2023
@notmandatory
Copy link
Member Author

notmandatory commented Feb 28, 2023

@afilini I'm a little worried that you intended to not shuffle inputs since your test verifies they're not shuffled. Do you remember is there's any reason not to shuffle the inputs?

@notmandatory
Copy link
Member Author

This doesn't seem like a critical issue so I'll re-do it for a future 1.0.0 alpha release after #793 is merged.

@notmandatory
Copy link
Member Author

Already fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TxOdering::Shuffle is not shuffling the inputs
1 participant