Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix spelling errors #1086

Merged
merged 1 commit into from
Sep 18, 2023
Merged

docs: fix spelling errors #1086

merged 1 commit into from
Sep 18, 2023

Conversation

notmandatory
Copy link
Member

Description

I did a global spell check and found and fixed a few spelling errors.

Notes to the reviewers

This is low priority but want to make sure it's done before we do a beta release.

Changelog notice

None.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Aug 21, 2023
@notmandatory notmandatory self-assigned this Aug 21, 2023
danielabrozzoni
danielabrozzoni reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you rebase to pick up the CI fixes?

@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.3 milestone Aug 22, 2023
@nondiremanuel
Copy link

I put it in alpha.3 milestone to indicate that ideally it needs to be fixed within beta version

@nondiremanuel nondiremanuel mentioned this pull request Aug 22, 2023
Closed
30 tasks
@evanlinjin
Copy link
Member

Time I install a spellchecker 😝

@nondiremanuel nondiremanuel mentioned this pull request Sep 10, 2023
Closed
41 tasks
realeinherjar
realeinherjar reviewed Sep 15, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
realeinherjar
realeinherjar approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 94f8fa5

evanlinjin
evanlinjin approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 94f8fa5

@danielabrozzoni danielabrozzoni merged commit 43fb0b2 into bitcoindevkit:master Sep 18, 2023
11 checks passed
@nondiremanuel nondiremanuel mentioned this pull request Sep 23, 2023
Closed
40 tasks
@realeinherjar realeinherjar mentioned this pull request Oct 26, 2023
Closed
45 tasks
@storopoli storopoli mentioned this pull request Jan 6, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielabrozzoni danielabrozzoni danielabrozzoni left review comments

@realeinherjar realeinherjar realeinherjar approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees

@notmandatory notmandatory

Labels
documentation Improvements or additions to documentation
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.
5 participants
@notmandatory @nondiremanuel @evanlinjin @danielabrozzoni @realeinherjar