Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use set_lookahead in set_lookahead_for_all #1104

Merged
merged 1 commit into from
Oct 7, 2023
Merged

refactor: use set_lookahead in set_lookahead_for_all #1104

merged 1 commit into from
Oct 7, 2023

Conversation

vladimirfomene
Copy link
Contributor

Description

Use set_lookahead in set_lookahead_for_all.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@vladimirfomene vladimirfomene force-pushed the simplify_set_lookahead_for_all branch from f73900e to e89cf5a Compare September 6, 2023 08:57
@nondiremanuel nondiremanuel mentioned this pull request Sep 10, 2023
Closed
41 tasks
@vladimirfomene vladimirfomene self-assigned this Sep 12, 2023
realeinherjar
realeinherjar approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@realeinherjar realeinherjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK: e89cf5a

set_lookahead does the same thing as what was replaced.

Check:

bdk/crates/chain/src/keychain/txout_index.rs

Lines 185 to 188 in c20a4da

pub fn set_lookahead(&mut self, keychain: &K, lookahead: u32) {
self.lookahead.insert(keychain.clone(), lookahead);
self.replenish_lookahead(keychain);
}

evanlinjin
evanlinjin approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e89cf5a

@evanlinjin evanlinjin merged commit 4a65a12 into bitcoindevkit:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@realeinherjar realeinherjar realeinherjar approved these changes

Assignees

@vladimirfomene vladimirfomene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladimirfomene @evanlinjin @realeinherjar