Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to bitcoin::FeeRate #1216

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Migrate to bitcoin::FeeRate #1216

merged 5 commits into from
Mar 22, 2024

Commits on Mar 22, 2024

  1. refactor(bdk)!: drop FeeRate from bdk::types 

    Adopt `bitcoin::FeeRate` throughout
    @ValuedMammal
    ValuedMammal committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    004957d View commit details
    Browse the repository at this point in the history

  2. test(bdk): initialize all feerates from u64 

    This makes the helper `feerate_unchecked` now redundant but
still usable.
    @ValuedMammal
    ValuedMammal committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    09bd86e View commit details
    Browse the repository at this point in the history

  3. refactor(bdk): display CreateTxError::FeeRateTooLow in sat/vb 

    Also modify a unit test `test_bump_fee_low_fee_rate` to
additionally assert the expected error message
    @ValuedMammal
    ValuedMammal committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    89608dd View commit details
    Browse the repository at this point in the history

  4. chore: organize some imports

    @ValuedMammal
    ValuedMammal committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    0d64beb View commit details
    Browse the repository at this point in the history

  5. refactor(bdk)!: Remove trait Vbytes 

    The only place this is being used is a unit test that is
easily refactored. For size conversions prefer methods
on e.g. `Weight`.
    @ValuedMammal
    ValuedMammal committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    475a772 View commit details
    Browse the repository at this point in the history