Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos #1220

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: fix typos #1220

merged 1 commit into from
Nov 16, 2023

Conversation

realeinherjar
Copy link
Contributor

@realeinherjar realeinherjar commented Nov 15, 2023 •
edited
Loading

Description

Fixes the typos and remove unused speculos dockerfiles that was done in #1165.
Moving these changes into this PR to be merged first.
Then, we can rebase #1165 and make it only related to CI and Nix.
(Maybe do a big squash 😄)

Note to Reviewers

About the speculos stuff, we are not using them, removed in #793,
more specifically in 3f5a78a.

Changelog notice

  • Fix typos in codebase and docs
  • Remove unused CI tests with hardware signer Dockerfiles

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@realeinherjar
Copy link
Contributor Author

Cc @danielabrozzoni

danielabrozzoni
danielabrozzoni reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a couple of comments

ci/Dockerfile.ledger Outdated Show resolved Hide resolved
.github/workflows/code_coverage.yml Show resolved Hide resolved
danielabrozzoni
danielabrozzoni approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 27a63ab

@danielabrozzoni danielabrozzoni merged commit cc552c5 into bitcoindevkit:master Nov 16, 2023
11 checks passed
@realeinherjar realeinherjar deleted the einherjar/typos-fmt branch November 16, 2023 13:34
@realeinherjar realeinherjar changed the title chore: fix typos and remove unused speculos dockerfiles chore: fix typos Nov 16, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.3 milestone Nov 16, 2023
@ValuedMammal ValuedMammal mentioned this pull request Nov 20, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielabrozzoni danielabrozzoni danielabrozzoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
3 participants
@realeinherjar @danielabrozzoni @notmandatory