Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin url dependency version to build with rust 1.63 #1470

Merged
merged 1 commit into from
Jun 12, 2024
Merged

ci: pin url dependency version to build with rust 1.63 #1470

merged 1 commit into from
Jun 12, 2024

Conversation

notmandatory
Copy link
Member

Description

Required because upstream dependency url changed their MSRV to 1.67 in a patch release.

Notes to the reviewers

See related discussion here: servo/rust-url#937

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jun 11, 2024
@notmandatory notmandatory self-assigned this Jun 11, 2024
LLFourn
LLFourn approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@LLFourn LLFourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 25b914b

@LLFourn LLFourn merged commit 473ef97 into bitcoindevkit:master Jun 12, 2024
12 checks passed
@notmandatory notmandatory deleted the ci/pin_url_dep branch June 12, 2024 00:39
@oleonardolima oleonardolima mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LLFourn LLFourn LLFourn approved these changes

Assignees

@notmandatory notmandatory

Labels
ci
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@notmandatory @LLFourn