Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(esplora): bump esplora-client to 0.10.0 #1626

Merged
merged 1 commit into from
Oct 1, 2024
Merged

deps(esplora): bump esplora-client to 0.10.0 #1626

merged 1 commit into from
Oct 1, 2024

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Sep 26, 2024 •
edited
Loading

Bumps rust-esplora-client to 0.10.0

also fixes #1120

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal self-assigned this Sep 26, 2024
@ValuedMammal ValuedMammal added this to the 1.0.0-beta milestone Sep 26, 2024
@oleonardolima
Copy link
Contributor

oleonardolima commented Sep 26, 2024 •
edited
Loading

I wonder, should we update the current bdk_esplora documentation to mention the new behavior ?

I thought about this again, I don't it's needed, anyone using it will need to setup the EsploraClient, and should check it on esplora-client's documentation instead.

oleonardolima
oleonardolima approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c605294

@LagginTimes
Copy link
Contributor

ACK c605294

notmandatory
notmandatory approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c605294

@notmandatory notmandatory merged commit d1f453e into bitcoindevkit:master Oct 1, 2024
21 checks passed
@ValuedMammal ValuedMammal deleted the deps/bump-esplora-client branch October 2, 2024 14:41
@ValuedMammal ValuedMammal mentioned this pull request Oct 2, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

@notmandatory notmandatory notmandatory approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.

wallet_esplora_async returns error 429 while scanning
4 participants
@ValuedMammal @oleonardolima @LagginTimes @notmandatory