fix(wallet): build with no default features #1635
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate for fixing an issue preventing
bdk_wallet
to build with no default features.Something to do with #1625 changed the way
bdk_wallet
resolves its dependency on rust-miniscript. Runningcargo build -p bdk_wallet --no-default-features
from the workspace root returnsI started by adding the "no-std" feature to the miniscript dependency in Cargo.toml which caused compilation to fail again because
Condition
is notOrd
so I added that here but there might be an alternative solution I haven't thought of.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: