Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(file_store): Document that it's a dev database #1661

Merged

Conversation

LLFourn
Copy link
Contributor

@LLFourn LLFourn commented Oct 27, 2024

Document bdk_file_store is a development/testing database

Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4b5bd0b

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4b5bd0b

@@ -1,5 +1,7 @@
# BDK File Store

> ⚠ `bdk_file_store` is a development/testing database. It does not natively support backwards compatible BDK version upgrades so should not be used in production.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally make it even clearer by using bold and uppercase.

Suggested change
> `bdk_file_store` is a development/testing database. It does not natively support backwards compatible BDK version upgrades so should not be used in production.
> `bdk_file_store` is a development/testing database. It does not natively support backwards compatible BDK version upgrades so *SHOULD NOT BE USED IN PRODUCTION*.

@LagginTimes
Copy link
Contributor

ACK 4b5bd0b

@ValuedMammal ValuedMammal merged commit 493638e into bitcoindevkit:master Oct 31, 2024
21 checks passed
@notmandatory notmandatory added this to the 1.0.0-beta milestone Oct 31, 2024
@notmandatory notmandatory added the documentation Improvements or additions to documentation label Oct 31, 2024
@LLFourn LLFourn deleted the bdk_file_store_is_for_development branch November 18, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants