exposing get_funded_wallet

[ulrichard]

• moving get_funded_wallet out of the test section to make it available for https://github.com/ulrichard/bdk-reserves
• moving the wallet::network() getter function to make it more accessable for https://github.com/ulrichard/bdk-reserves

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[notmandatory]

This looks good, my only concern is exposing test functions in the release builds for bdk. I think it should be possible to put any test utility functions behind a feature flag. I'm working on testing that in another fork and if I get it to works I'll make some suggestions on how to add something like a test-wallet feature as part of this PR or as a follow-up PR.

[notmandatory]

BTW, my PR to add the feature gates as a follow up to this PR is #412 Looks like enabling features only for tests isn't currently possible.

[notmandatory]

ACK 29f32d8

[ulrichard]

Thanks for testing that stuff.
Yes rust-lang/cargo#2911 would be really cool.

[tcharding]

Perhaps we should put this behind #[cfg(debug_assertions)] so its only available in debug builds?

[ulrichard]

Perhaps we should put this behind #[cfg(debug_assertions)] so its only available in debug builds?

That looks like a good idea. I quickly tried it and executed a few commands that came to my mind. The only one that failed was:
cargo test --release
But I don't know if that is actually used by anybody.

[afilini]

I think fuzzing is generally done by compiling to release mode with tests enabled. I don't think it's really a problem if it's available in release mode to be honest, I would just leave it in there

[afilini]

Did you try with #[cfg(test)] to see if you could hide this to non-testing environments?

I didn't realize this yesterday, I thought this was still part of the test module, which is only present when testing is enabled.

[ulrichard]

If I add this, then I get the following error in bdk-reserves: "unresolved import bdk::wallet::get_funded_wallet"

And if I try the following in bdk-reserves/Cargo.toml: "bdk = { ... features = ["electrum", "test"] }" then I get the following error: "the package bdk-reserves depends on bdk, with features: test but bdk does not have these features."

It would be cool to make it work like this, but I don't know how.