Improve display error formatting #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukibtc
force-pushed
the
displayerrorformatting
branch
from
c36a18f to
d01e822
Compare
|
Alternate proposal.. Why not use @afilini @notmandatory does that sound like a good approach to take? If yes, @yukibtc are willing to change this PR into that? |
|
Personally that looks more cleaner to me.. |
Yes, me too. I re-opened the PR #813. |
|
For reviewers: This is competing to #813 .. |
6 tasks
LLFourn
reviewed
Jan 9, 2023
src/error.rs
Outdated
| Self::Miniscript(err) => write!(f, "Miniscript error: {}", err), | ||
| Self::MiniscriptPsbt(err) => write!(f, "Miniscript PSBT error: {}", err), | ||
| Self::Bip32(err) => write!(f, "BIP32 error: {}", err), | ||
| Self::Secp256k1(err) => write!(f, "ECDSA error: {}", err), |
There was a problem hiding this comment.
I don't think this error is necessarily ECDSA?
yukibtc
force-pushed
the
displayerrorformatting
branch
from
d01e822 to
fbf4cb0
Compare
24 tasks
|
We've bumped MSRV to 1.57.0, please rebase. |
yukibtc
force-pushed
the
displayerrorformatting
branch
from
fbf4cb0 to
9019793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #555
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: