Bump hwi to 0.4.0 #825
Bump hwi to 0.4.0 #825
Conversation
danielabrozzoni
force-pushed
the
bump_rust_hwi
branch
from
01a614a to
9e6bf42
Compare
danielabrozzoni
force-pushed
the
bump_rust_hwi
branch
from
9e6bf42 to
4cad18b
Compare
There was a problem hiding this comment.
Review ACK..
I am thinking how about adding a link to https://github.com/bitcoin-core/HWI in the doc above for people who don't know where to get the hwi python package from..
| println!( | ||
| "The hardware wallet's descriptor is: {}", | ||
| descriptors.receive[0] | ||
| ); | ||
|
|
||
| // Creating a custom signer from the device | ||
| let custom_signer = HWISigner::from_device(first_device, HWIChain::Test)?; | ||
| let custom_signer = HWISigner::from_device(&first_device, HWIChain::Test)?; |
There was a problem hiding this comment.
I am hitting an OSError at this line with my coldcard.. Any guess?
Hold tight, I'm connecting to your hardware wallet...
No module named 'hwilib.devices.jadepy.jade_ble'
BLE scanning/connectivity will not be available
Look what I found, a coldcard!
The hardware wallet's descriptor is: pkh([ef2dfe99/44'/1'/0']tpubDDEc4pGkD8MPWq2D1DGb3DWH2RcXTe9cZYGqgFBGwYRA7rgf1uZop65ptiiKCKB12vS4UrysKucmdjFwjhVzpwNmcVNBXd84uqtj8TYLuVx/0/*)#ktdw6k4n
Error: PyErr("OSError: open failed")
|
Should we try to get this into the 0.26.0 release? The code freeze was supposed to be today..but will probably delayed a few days.. |
I think it'd be cool if we can make it :) @rajarshimaitra can you try with bdk from master? It's possible that you'll hit the same error, in which case it's definitely to fix, but at least we know that it wasn't introduced in this PR :) |
Yes I am hitting the same one in master too.. |
|
@rajarshimaitra since you're getting the same error on |
I think it is! :) |
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing