Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't default to use async/await on wasm32 #831

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Don't default to use async/await on wasm32 #831

merged 1 commit into from
Jan 30, 2023

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jan 10, 2023

Description

We don't automatically want to make the interface async based on the used architecture, but now require the user to explicitly set the async-interface feature.

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

This was referenced Jan 10, 2023
Closed
Merged
@tnull tnull force-pushed the 2023-01-macros-dont-default-to-async-on-wasm branch 4 times, most recently from 6aa070b to 033e413 Compare January 10, 2023 18:11
@notmandatory
Copy link
Member

@tnull this looks good to me, it just needs a rebase to update CI after #815 change stable rust to 1.65. Thanks!

@tnull tnull force-pushed the 2023-01-macros-dont-default-to-async-on-wasm branch from 033e413 to eb11679 Compare January 24, 2023 18:19
@tnull
Copy link
Contributor Author

tnull commented Jan 24, 2023

@tnull this looks good to me, it just needs a rebase to update CI after #815 change stable rust to 1.65. Thanks!

Now rebased on master.

@tnull
Copy link
Contributor Author

tnull commented Jan 24, 2023

@notmandatory Mh, seems the CI failures are unrelated as they also happen on current master?

@notmandatory
Copy link
Member

@notmandatory Mh, seems the CI failures are unrelated as they also happen on current master?

Oh drat.. I'm looking into it now.

@notmandatory
Copy link
Member

Please take a look and hold off on rebasing until we decide on this PR: #842

@notmandatory
Copy link
Member

We've bumped MSRV to 1.57.0, please rebase.

@tnull
Don't default to use async/await on wasm32
32912ea 
We don't automatically want to make the interface `async` based on the
used architecture, but now require the user to explicitly set the
`async-interface` feature.
@tnull tnull force-pushed the 2023-01-macros-dont-default-to-async-on-wasm branch from eb11679 to 32912ea Compare January 27, 2023 17:09
@tnull
Copy link
Contributor Author

tnull commented Jan 27, 2023

We've bumped MSRV to 1.57.0, please rebase.

Rebased on master.

notmandatory
notmandatory approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 32912ea

@notmandatory notmandatory merged commit 41dc7f7 into bitcoindevkit:master Jan 30, 2023
@notmandatory notmandatory mentioned this pull request Feb 2, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@tnull tnull

Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.27.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.
2 participants
@tnull @notmandatory