Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-miniscript to 9.0 #844

Merged

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Jan 26, 2023

Description

A new rust-miniscript release 9.0 came out on Nov 14, updating to it to pickup the bug fixes. Also updating dependencyhwi to new 0.5 version which used the 9.0 version of rust-miniscript.

Notes to the reviewers

This new version of rust-miniscript uses the same version of rust-bitcoin we are on, 0.29.1.

Changelog notice

Update rust-miniscript dependency to latest bug fix release 9.0.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Jan 26, 2023
@notmandatory notmandatory marked this pull request as draft January 27, 2023 17:24
@notmandatory notmandatory removed this from the Release 0.27.0 Feature Freeze milestone Jan 27, 2023
@notmandatory
Copy link
Member Author

notmandatory commented Jan 27, 2023

I removed this PR from next release.. I first need to update rust-hwi via bitcoindevkit/rust-hwi#69 to use rust-miniscript 9.0 and then get a new rust-hwi release out.

@notmandatory
Copy link
Member Author

notmandatory commented Jan 31, 2023

All tests passing with rust-hwi master branch, now only needs a new release of that crate.

@notmandatory
Copy link
Member Author

The updated rust-hwi release should be out this week so moving this PR back into the 0.27 release. Also because I'd like to get this in before bitcoindevkit/bdk-cli#135 goes in.

@notmandatory notmandatory marked this pull request as ready for review January 31, 2023 19:59
@notmandatory
Copy link
Member Author

This is only a dependency change so I'm not sure why coveralls is complaining that our code coverage went down. 🤷‍♂️

Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cf8cd2f

I have manually tested and all green..

@notmandatory notmandatory merged commit 0b26fa7 into bitcoindevkit:master Feb 2, 2023
@notmandatory notmandatory mentioned this pull request Feb 2, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants