Check results in the DB tests #857
Conversation
Just to make it clearer, the test failures were on your postresql database implementation, and not on our database implementations, correct? |
|
Clippy is complaining btw, otherwise it looks good to me |
Yes, that's correct, It hid the bugs that I had in my implementation. |
silvestrst-crypto
force-pushed
the
silvestrs/database-tests-minor-fixes
branch
2 times, most recently
from
c8fab6b to
5019d4c
Compare
|
Sorry to bother you again, can you rebase on master? Right now the CI is failing because of the hardware wallet job, and we have a fix on that in master. I sadly can't merge until the CI is green! |
No worries at all, I should have done it in the first place. Thanks :) |
Checksum test was giving a false positive due to ignoring the return value. Other tests were giving assertion fail later in the test, rather than an error on failed method call, thus making it more challenging to debug the issue. These have been discovered, when implementing PostgreSQL backend in a downstream fork.
silvestrst-crypto
force-pushed
the
silvestrs/database-tests-minor-fixes
branch
from
5019d4c to
a1a70a5
Compare
Description
Checksum test was giving a false positive due to ignoring the return value.
Other tests were giving assertion fail later in the test, rather than an error on failed method call, thus making it more challenging to debug the issue.
These have been discovered, when implementing PostgreSQL backend in a downstream fork.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingsqliteandkey-value-dbtests successfully