Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add article about changes in coin selection module #114

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Add article about changes in coin selection module #114

merged 1 commit into from
Nov 8, 2022

Conversation

csralvall
Copy link
Contributor

This blog post summarizes the work done during the Summer of Bitcoin
initiative in the coin selection module of BDK and the ideas projected
for its future.

@netlify
Copy link

netlify bot commented Aug 17, 2022 •
edited
Loading

✅ Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit f608e9e
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/6327228911b8ba0009b7b89d
😎 Deploy Preview https://deploy-preview-114--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@csralvall csralvall force-pushed the improving_coin_selection_blog_post branch 2 times, most recently from 1dfadb1 to fe9c9f1 Compare August 17, 2022 20:23
@notmandatory notmandatory mentioned this pull request Aug 28, 2022
Closed
27 tasks
@notmandatory notmandatory self-requested a review August 30, 2022 13:48
@notmandatory
Copy link
Member

@csralvall I added some small language suggestions, but the content is great! Coin selection is a tricky topic and you explained it well.

@notmandatory notmandatory mentioned this pull request Sep 13, 2022
Closed
26 tasks
@csralvall csralvall force-pushed the improving_coin_selection_blog_post branch from fe9c9f1 to 5523004 Compare September 17, 2022 10:36
@csralvall
Copy link
Contributor Author

@notmandatory, thanks for the review, and sorry for the late reply! I've addressed all your corrections and have added some other minor fixes.

@notmandatory
Copy link
Member

@notmandatory, thanks for the review, and sorry for the late reply! I've addressed all your corrections and have added some other minor fixes.

No problem @csralvall but I don't see any corrections here, double check that you pushed all your fixes to Github. Then I'm happy to merged this one.

@csralvall
Add article about changes in coin selection module
f608e9e 
This blog post summarizes the work done during the Summer of Bitcoin
initiative in the coin selection module of BDK and the ideas projected
for its future.
@csralvall csralvall force-pushed the improving_coin_selection_blog_post branch from 5523004 to f608e9e Compare September 18, 2022 13:52
@csralvall
Copy link
Contributor Author

@notmandatory, fixed! I forgot to add changes to the staging area.

@notmandatory notmandatory mentioned this pull request Sep 26, 2022
Closed
30 tasks
@notmandatory notmandatory mentioned this pull request Nov 7, 2022
Closed
24 tasks
notmandatory
notmandatory approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f608e9e

@notmandatory notmandatory merged commit 4b23961 into bitcoindevkit:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@csralvall csralvall

Labels
None yet
Projects
Documentation Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csralvall @notmandatory