Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bdk flutter tutorial #123

Merged
merged 17 commits into from
Jan 30, 2023

Conversation

BitcoinZavior
Copy link
Contributor

Added BDK-Flutter Tutorial

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit 0bf260d
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/63d80426cef510000d8965aa
😎 Deploy Preview https://deploy-preview-123--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@BitcoinZavior BitcoinZavior marked this pull request as ready for review October 18, 2022 13:06
@thunderbiscuit
Copy link
Member

thunderbiscuit commented Oct 25, 2022

I'm about halfway through the tutorial.

One comment I'd have is that for me, it's easier to clone the working app, run it, and then from there explore the files and see how it works rather than building from scratch and adding code one block at a time into an architecture I don't yet fully know/am familiar with.

So that's how I ended up navigating and using the tutorial, but of course that's just me. But that could be an extra paragraph you add at the beginning where you mention that another way of using this tutorial is to clone the fully working app and read along and explore the files as they are being explained.


Edit: now I also realize how this tutorial is not for beginners of Flutter anyway (you jump right into it, and I think that's indeed the right approach, you wouldn't want to get bogged down into explaining how to install Flutter and whatnot). So this is good, but it implies your reader is fairly familiar with mobile apps and Flutter. So I wonder if maybe that's how most people will want to consume the tutorial: clone a fully working sample app, and then follow the tutorial to explore it, rather than "building" it per se. Just my 2 cents.

Also, the app worked on the first try! So that's an absolute awesome dev experience. Congrats, this is really cool.

@notmandatory
Copy link
Member

I think we should hold off on this blog post until API issues with bdk-flutter (and bdk-rn) can be worked out and more closely aligned with bdk-ffi (and bdk). When I have some time I'll open some issues for your repos, and I see that @thunderbiscuit has already started. I just don't want to get any more confused new folks who want to use rn or flutter when those projects are not ready.

@BitcoinZavior
Copy link
Contributor Author

...closely aligned with bdk-ffi (and bdk)...
Ok, I have started aligning the methods in bdk-flutter to bdk-ffi already. Will wait to see what issues get openned before making a PR.

@notmandatory
Copy link
Member

@BitcoinZavior it's ok to start making PRs on your projects for aligning the APIs.. just ping me and @thunderbiscuit if you need help and/or review.

@BitcoinZavior
Copy link
Contributor Author

@BitcoinZavior it's ok to start making PRs on your projects for aligning the APIs.. just ping me and @thunderbiscuit if you need help and/or review.

OK, I will just follow https://github.com/bitcoindevkit/bdk-ffi/blob/master/src/bdk.udl which is what bdk-ffi follows as well.

@BitcoinZavior
Copy link
Contributor Author

BitcoinZavior commented Dec 4, 2022

I think we should hold off on this blog post until API issues with bdk-flutter (and bdk-rn) can be worked out and more closely aligned with bdk-ffi (and bdk). When I have some time I'll open some issues for your repos, and I see that @thunderbiscuit has already started. I just don't want to get any more confused new folks who want to use rn or flutter when those projects are not ready.

@notmandatory All code snippets have now been updated to align with the latest bdk-flutter updates, which in turn has been updated to align with ffi api 😊

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I recognize all the APIs, and the wallet builds and works locally. I have some questions that are more for my own understanding of the bindings (nothing blocking), which I'll ask on the Discord server.

ACK dc78b38.

@notmandatory
Copy link
Member

Looks good to me, but can you squash and sign your commits? Then it should be ready to merge. Thanks!

@notmandatory
Copy link
Member

@BitcoinZavior in our last dev call you mentioned there were a few little updates you wanted to make. Let me know when you think it's ready to go.

@notmandatory
Copy link
Member

This will also need a final rebase to merge cleanly.

@BitcoinZavior
Copy link
Contributor Author

@notmandatory Finally all done, tested the quickstart app with the published package and made final tweaks.

@notmandatory notmandatory merged commit 0bf260d into bitcoindevkit:master Jan 30, 2023
@notmandatory
Copy link
Member

@BitcoinZavior It's finally in! thanks for all the updates and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants