-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BDK version and the sample code #136
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/getting-started.md
Outdated
More information about each component used in the code can be found in [BDK Documentation](https://docs.rs/bdk/0.26.0/bdk/index.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More information about each component used in the code can be found in [BDK Documentation](https://docs.rs/bdk/0.26.0/bdk/index.html). | |
More information about each component used in the code can be found in [BDK Documentation](https://docs.rs/bdk/latest/bdk/index.html). |
Also there are several other doc link that point to 0.15.0 (lines 47-40)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree best to point this link to latest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 844687b
I think this one is ready to go after above suggestion added and also a rebase to make it easier to merge. |
844687b
to
0ee7901
Compare
Rebased and the suggestion above was added. |
Thanks, looks good, but not the the 0.27 version of bdk is out. Please update cargo examples to version "0.27" this will pick up new patch versions and since we're staying on 0.27.X most likely until 1.0.0 is ready these docs won't need to be changed again right away. |
I assume the links now need to be updated to point to the 0.28.0 version. @w0xlt let me know if you'd like me to apply required fixes and we'll get this in before it becomes outdated again! |
0ee7901
to
c0e865b
Compare
c0e865b
to
3b22c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3b22c8d.
Update BDK version and the sample code to 0.26