Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BDK version and the sample code #136

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

w0xlt
Copy link
Contributor

@w0xlt w0xlt commented Jan 11, 2023

Update BDK version and the sample code to 0.26

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit 3b22c8d
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/64cd15a69962a900085ffc09
😎 Deploy Preview https://deploy-preview-136--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

More information about each component used in the code can be found in [BDK Documentation](https://docs.rs/bdk/0.26.0/bdk/index.html).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
More information about each component used in the code can be found in [BDK Documentation](https://docs.rs/bdk/0.26.0/bdk/index.html).
More information about each component used in the code can be found in [BDK Documentation](https://docs.rs/bdk/latest/bdk/index.html).

Also there are several other doc link that point to 0.15.0 (lines 47-40)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree best to point this link to latest.

Copy link
Contributor Author

@w0xlt w0xlt Jan 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 844687b

@notmandatory
Copy link
Member

I think this one is ready to go after above suggestion added and also a rebase to make it easier to merge.

@w0xlt w0xlt force-pushed the update_to_0_26 branch 2 times, most recently from 844687b to 0ee7901 Compare January 29, 2023 01:00
@w0xlt
Copy link
Contributor Author

w0xlt commented Jan 29, 2023

Rebased and the suggestion above was added.

@notmandatory
Copy link
Member

Thanks, looks good, but not the the 0.27 version of bdk is out. Please update cargo examples to version "0.27" this will pick up new patch versions and since we're staying on 0.27.X most likely until 1.0.0 is ready these docs won't need to be changed again right away.

@thunderbiscuit
Copy link
Member

I assume the links now need to be updated to point to the 0.28.0 version. @w0xlt let me know if you'd like me to apply required fixes and we'll get this in before it becomes outdated again!

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3b22c8d.

@thunderbiscuit thunderbiscuit merged commit 3b22c8d into bitcoindevkit:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants