Make LowestFee metric better
#6
Labels
Comments
jp1ac4
added a commit
to jp1ac4/liana
that referenced
this issue
Dec 11, 2023
This is a partial fix for bitcoindevkit/coin-select#6. When calculating the score, the excess should be added to changeless solutions instead of those with change. Given a solution has been found, this fix adds or removes the excess to its incorrectly calculated score as required so that two changeless solutions can be differentiated if one has higher excess (and therefore pays a higher fee). Note that the `bound` function is also affected by this bug, which could mean some branches are not considered when running BnB, but at least this fix will mean the score for those solutions that are found is correct.
jp1ac4
added a commit
to jp1ac4/liana
that referenced
this issue
Dec 11, 2023
This is a temporary partial fix for bitcoindevkit/coin-select#6 that should be reverted once the upstream fix has been made. When calculating the score, the excess should be added to changeless solutions instead of those with change. Given a solution has been found, this fix adds or removes the excess to its incorrectly calculated score as required so that two changeless solutions can be differentiated if one has higher excess (and therefore pays a higher fee). Note that the `bound` function is also affected by this bug, which could mean some branches are not considered when running BnB, but at least this fix will mean the score for those solutions that are found is correct.
jp1ac4
added a commit
to jp1ac4/liana
that referenced
this issue
Dec 12, 2023
This is a temporary partial fix for bitcoindevkit/coin-select#6 that should be reverted once the upstream fix has been made. When calculating the score, the excess should be added to changeless solutions instead of those with change. Given a solution has been found, this fix adds or removes the excess to its incorrectly calculated score as required so that two changeless solutions can be differentiated if one has higher excess (and therefore pays a higher fee). Note that the `bound` function is also affected by this bug, which could mean some branches are not considered when running BnB, but at least this fix will mean the score for those solutions that are found is correct.
darosior
added a commit
to wizardsardine/liana
that referenced
this issue
Dec 12, 2023
5f534eb spend: a temporary partial fix for `LowestFee` (jp1ac4) Pull request description: This is a temporary partial fix for bitcoindevkit/coin-select#6 that should be reverted once the upstream fix has been made. When calculating the score, the excess should be added to changeless solutions instead of those with change. Given a solution has been found, this fix adds or removes the excess to its incorrectly calculated score as required so that two changeless solutions can be differentiated if one has higher excess (and therefore pays a higher fee). Note that the `bound` function is also affected by this bug, which could mean some branches are not considered when running BnB, but at least this fix will mean the score for those solutions that are found is correct. The new functional test included here fails without this fix. ACKs for top commit: darosior: ACK 5f534eb Tree-SHA512: f3a0e67434cad005389a938c0833394ff2c242d262f1ed1e6da9d1ce403af221bbce265a6fe67ad72f8fa8b461530faac1387c980f7f539cbb187603371c58d7
|
I did this in #13. It is certainly "better" (as in not completely broken) now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bdk_coin_selectimplementation bdk#1072 (comment)bdk_coin_selectimplementation bdk#1072 (comment)The text was updated successfully, but these errors were encountered: