Skip to content

Conversation

@ValuedMammal
Copy link
Contributor

PR updates the pinned dependencies to build on MSRV. Opening this to test out the changes in CI.

  • pin tracing-core to 0.1.33
  • pin parking_lot to 0.12.3
  • pin parking_lot_core to 0.9.10
  • pin lock_api to 0.4.12

- pin `parking_lot` to 0.12.3
- pin `parking_lot_core` to 0.9.10
- pin `lock_api` to 0.4.12
@coveralls
Copy link

coveralls commented Jun 17, 2025

Pull Request Test Coverage Report for Build 15916690381

Details

  • 17 of 19 (89.47%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 87.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/async.rs 1 2 50.0%
src/blocking.rs 13 14 92.86%
Totals Coverage Status
Change from base Build 14597440477: -0.6%
Covered Lines: 1052
Relevant Lines: 1201

💛 - Coveralls

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 3178d17

I wasn't able to find any new pinned deps that aren't needed.

I had to fix new rust 1.88 clippy warnings.

@notmandatory notmandatory added the ci Continuous Integration issues label Jun 27, 2025
@notmandatory notmandatory merged commit 030f823 into bitcoindevkit:master Jun 27, 2025
25 checks passed
@ValuedMammal ValuedMammal deleted the update_ci branch June 27, 2025 14:09
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
…re` to 0.1.33

3178d1734f85523353bf78e690aef9aceb091124 ci: fix new clippy uninlined_format_args warning (Steve Myers)
fd5857e9cb9baf9a2a99ed7e0a917e2deb0a7887 ci,msrv: pin `tracing-core` to 0.1.33 (valued mammal)

Pull request description:

  PR updates the pinned dependencies to build on MSRV. Opening this to test out the changes in CI.

  - pin `tracing-core` to 0.1.33
  - pin `parking_lot` to 0.12.3
  - pin `parking_lot_core` to 0.9.10
  - pin `lock_api` to 0.4.12

ACKs for top commit:
  notmandatory:
    tACK 3178d1734f85523353bf78e690aef9aceb091124

Tree-SHA512: 45437008408201606da88a664ab33cb30df6e3ba2d03ec77e7c914bc527fc7cace9922f8e484467b89e9950cc3796bdea8581870af38c574da61ee23050f0a81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants