Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pin tokio to 1.38.1 on MSRV step #94

Conversation

oleonardolima
Copy link
Collaborator

Description

As previously noticed on bitcoindevkit/bdk#1524, tokio raised their MSRV to 1.70.0 in their latest release, in short it was because they moved to mio 1.0 which requires 1.70.0 MSRV.

Although we don't have tokio as a direct dependency on rust-esplora-client it comes as a transitive dependency from reqwest.

This PR adds the necessary pinning on CI and updates the instruction on README.md in order to properly build on MSRV.

Notes to the reviewers

Changelog notice

  • Adds another MSRV pinning step on CI for the tokio 1.38.1.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@oleonardolima oleonardolima changed the title fix(ci): pin tokio to 1.38.1 on msrv step fix(ci): pin tokio to 1.38.1 on MSRV step Aug 22, 2024
@oleonardolima oleonardolima self-assigned this Aug 22, 2024
@oleonardolima oleonardolima added the ci Continuous Integration issues label Aug 22, 2024
@oleonardolima oleonardolima marked this pull request as ready for review August 22, 2024 14:21
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 16cdd38

Thanks for fixing this here!

@notmandatory notmandatory merged commit dbf3aa8 into bitcoindevkit:master Aug 22, 2024
23 checks passed
@oleonardolima oleonardolima deleted the fix/ci-msrv-pin-tokio-to-1.38.1 branch August 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants