Bump rust-bitcoin to 0.29 #50
Comments
|
@danielabrozzoni I think BDK is almost ready for this one now that rust-miniscript 0.8 is release with rust-bitcoin 0.29. Are you already working on a PR? |
8 tasks
|
I just have to re-apply 91b8e3c :) |
notmandatory
added a commit
to bitcoindevkit/bdk
that referenced
this issue
Oct 27, 2022
c7a43d9 Remove unused code (Alekos Filini) 1ffd59d Upgrade to rust-bitcoin 0.29 (Alekos Filini) ae4f4e5 Upgrade `rand` to `0.8` (Alekos Filini) 9854fd3 Remove deprecated address validators (Alekos Filini) Pull request description: ### Description Upgrade BDK to rust-bitcoin 0.29 Missing pieces: - [x] rust-miniscript `update_output_with_descriptor` - rust-bitcoin/rust-miniscript#465 - [x] rust-miniscript 8.0.0 release - rust-bitcoin/rust-miniscript#462 - [x] Upgrade rust-hwi to bitcoin 0.29 bitcoindevkit/rust-hwi#50 - [x] Upgrade esplora-client to bitcoin 0.29 bitcoindevkit/rust-esplora-client#20 - [x] Upgrade rand to 0.8 like secp256k1 did ### Notes to the reviewers The commits still need to be reordered and cleaned up ### Changelog notice - Upgrade rust-bitcoin to 0.29 - Remove deprecated "address validators" ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK c7a43d9 Tree-SHA512: 718a1baf3613b31ec1de39fe63467ebee38617963a4ce0670a617e20fe4f46a57c5786933cdde6cfad9fc76ce0af08843f58844fb4a89f5948cb42c697f802ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had to revert 91b8e3c for 0.2.3 (we needed the update in bdk, and bdk is still stuck at 0.28). Re-revert the commit for the next release.
The text was updated successfully, but these errors were encountered: