Skip to content

Fix error TS2339: Property valueBuffer does not exist on type OpenOutput #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2019
Merged

Fix error TS2339: Property valueBuffer does not exist on type OpenOutput #1506

merged 2 commits into from
Nov 21, 2019

Conversation

longhoangwkm
Copy link
Contributor

@longhoangwkm longhoangwkm commented Nov 20, 2019 •
edited
Loading

@junderw @longhoangwkm
Fix Transaction Output type
2aa3926 
Co-authored-by: longhoang.wkm <longhoang@wakumo.vn>
@junderw junderw force-pushed the fix-property-doesnt-exist-error-types branch from e5a191b to 2aa3926 Compare November 21, 2019 07:35
junderw
junderw previously approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BlankOutput interface has no use externally, so I got rid of it.

@junderw junderw merged commit 29e3195 into bitcoinjs:master Nov 21, 2019
@rained23
Copy link

rained23 commented Jan 3, 2020

When will this be available in stable release?

@junderw
Copy link
Member

junderw commented Jan 6, 2020

published as 5.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't get value of output
3 participants
@longhoangwkm @rained23 @junderw