Fix taproot sig validation again. #1935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1934
The last PR made the "should be invalid" sig invalid because I was chopping off the wrong byte of the 65 byte signature.
After fixing it, I noticed we didn't actually fix the previous issue either.
This time we actually fixed the issue.
The problem was the assumption that the transaction is always using the "tweak the internal pubkey with a hash of itself" method.
Removing that assumption should fix the issue.
@motorina0 Please review the source and see my comments below first.