-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topics: add multiple topics for Newsletter 283 #1452
Conversation
360de7e
to
94e77b2
Compare
Rebased on master |
_topics/en/pcac.md
Outdated
@@ -0,0 +1,101 @@ | |||
--- | |||
title: Payments Contingent on Anything Computable (PCAC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will probably rename this to Accountable Computing Contracts (ACC); see https://twitter.com/hrdng/status/1742597010967118177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting these together @harding !
_topics/en/ark.md
Outdated
## Required. Use Markdown formatting. Only one paragraph. No links allowed. | ||
## Should be less than 500 characters | ||
excerpt: > | ||
**Ark** is a trustless joinpool-style protocol where a large numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Ark** is a trustless joinpool-style protocol where a large numbers | |
**Ark** is a trustless joinpool-style protocol where a large number |
_topics/en/ark.md
Outdated
--- | ||
The users can either unilaterally withdraw their bitcoins onchain | ||
after the expiry of the time period or instantly and trustlessly | ||
transfer them offchain to the counterparty before the end of the time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I took the "transferring them offchain to the counterparty" as "paying" the counterparty at this point in the writeup. Although its cleared up a bit in the next sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rewrote the following sentence, but I'm not sure how to avoid the confusion in this sentence without making it inaccurate. In Ark, all payments have to go through the counterparty (unless they're unilateral withdrawals to your pre-committed withdrawal address).
_topics/en/ark.md
Outdated
their individual costs. | ||
|
||
--- | ||
The users can either unilaterally withdraw their bitcoins onchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: other topics seem to not have leading spaces after the excerpt
_topics/en/expiration-floods.md
Outdated
excerpt: > | ||
**Expiration floods** occur when many timelock-contingent payments are | ||
broadcast simultaneously. If not all of them can fit into blocks | ||
before their timelocks begin expiring, users are guaranteed to lose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"guaranteed"-> depends on the contract?
_topics/en/expiration-floods.md
Outdated
## Required. Use Markdown formatting. Only one paragraph. No links allowed. | ||
## Should be less than 500 characters | ||
excerpt: > | ||
**Expiration floods** occur when many timelock-contingent payments are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe transactions instead of payments here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was definitely misleading before. Thanks! I think I've clarified it, let me know.
_topics/en/expiration-floods.md
Outdated
their channels simultaneously, e.g. a bug in a software implementation. | ||
In the accidental case, some honest users will get their money and other | ||
honest users may not, even though they all followed the protocol | ||
faithfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe?
faithfully. | |
correctly. |
_topics/en/expiration-floods.md
Outdated
transactions during an expiration flood. [Proposals][friedenbach | ||
dynamic] of this [nature][maxwell dynamic] | ||
usually require miners to pay a cost for creating higher blocks, such | ||
as destroying bitcoins are generating more proof of work. The lost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as destroying bitcoins are generating more proof of work. The lost | |
as destroying bitcoins or generating more proof of work. The lost |
_topics/en/matt.md
Outdated
## Required. Use Markdown formatting. Only one paragraph. No links allowed. | ||
## Should be less than 500 characters | ||
excerpt: > | ||
**MATT** is a soft fork proposal that would add a `OP_CHECKCONTRACTVERIFY` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**MATT** is a soft fork proposal that would add a `OP_CHECKCONTRACTVERIFY` | |
**MATT** is a soft fork proposal that would add an `OP_CHECKCONTRACTVERIFY` |
_topics/en/pcac.md
Outdated
|
||
## Optional. An entry will be added to the topics index for each alias | ||
aliases: | ||
- BitVM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MATT now could support this as well. Do we list all of them here as aliases? Or MATT is in the see also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't list any existing topic in an alias as the list of topics on https://bitcoinops.org/en/topics/ is built from names + aliases, so having a topic and an alias with the same name would be a conflict. I'm not actually sure what happens if we accidentally did that; I should make sure that fails or is otherwise tested for. More directly, I think of MATT now as offering a superset of functionality to the behavior described on this page, kinda like how vaults could use CTV but CTV can also do other things. We wouldn't list CTV as an alias for vaults, so I don't think MATT should be an alias for ACC.
ZKCP and BitVM are strictly for ACCs and I don't plan to split them off into separate topics unless one of them starts getting mentioned a lot.
_topics/en/pcac.md
Outdated
that hash digest. If Alice doesn't disclose it, Bob can reclaim his | ||
funds after the HTLC timelock expires. | ||
|
||
- [BitVM][] allows both Bob to deposit money into a contract that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [BitVM][] allows both Bob to deposit money into a contract that | |
- [BitVM][] allows Bob to deposit money into a contract that |
94e77b2
to
875c97c
Compare
Updated (force push) for all @bitschmidty feedback, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 875c97c
But Ill refrain from merging for the moment in anticipation of more review. If anyone would like to merge sooner, go for it.
875c97c
to
08bfd5b
Compare
Moved Ark topic to #1468 |
If there are no further comments on this, I plan to merge it on Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on #1451 ; this PR is only for the last commit.
I had a bunch of topic pages I wanted to add for Newsletter 283 but I think they need some review before we publish, so I'm opening this PR instead. Included is an edit to News283 to include the links to the topic pages. That slightly violates our no-significant-edits-after-publication policy, but that newsletter was really meant to link to these topics, so I think that's ok.