-
Notifications
You must be signed in to change notification settings - Fork 145
Newsletters: add 294 (2024-03-20) #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I like especially the idea to clarify that recently merged Bitcoin Core commits will only be shipped in the next release
| *Note: the commits to Bitcoin Core mentioned below apply to its master | ||
| development branch and so those changes will likely not be released | ||
| until about six months after the release of the upcoming version 27.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'm a fan of this note, or mentioning specifically Bitcoin Core and not the others. How about permanently amending the introductory paragraph like this?
"These changes are expected to be included in future releases of the respective projects."
(Although this is a bit inaccurate since BIPs, BOLTs and BINANAs don't have releases.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous discussion here: #395 (comment)
We haven't included this note for a while, but I saw some confusion on Twitter about whether recent merges would be included in the upcoming release, so I decided to re-instate it. I don't think the note generalizes, as only Bitcoin Core has this behavior; see this quote from the previous discussion:
AFAICT, Bitcoin Core is the only project we monitor that branches from master prior to a major release. (Indeed, I'm unable to think of any other free software project I've followed that does that.)
I'm happy to discuss further, but I suggest we include the note this week as we've included it many times before.
| currently used by [LN anchor outputs][topic anchor outputs]. V3 | ||
| transaction relay is not currently enabled for mainnet and (as noted | ||
| above) this PR is merged into the development branch that is not | ||
| expected to be released for about six months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of repeating the above note, how about just:
| currently used by [LN anchor outputs][topic anchor outputs]. V3 | |
| transaction relay is not currently enabled for mainnet and (as noted | |
| above) this PR is merged into the development branch that is not | |
| expected to be released for about six months. | |
| currently used by [LN anchor outputs][topic anchor outputs]. V3 | |
| transaction relay remains disabled on mainnet. |
|
Added lede, releases/RC, and topic links. Made all suggested edits (or left a reply), thanks everyone! Also reviewed the client/services section (thanks Mike!). |
06fe125 to
0c7417f
Compare
bitschmidty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK lede, topics (I made one small change), kindred replace by fee topic addition, and made sure all comments were resolved, squashed
murchandamus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a review and forgot to submit it. 🤦
| signals_bip125: "true" | ||
| list: "true" | ||
| details: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m wondering whether there should also be an update of the "date tested" or the receive side here.
Uh oh!
There was an error while loading. Please reload this page.