Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Mar 18, 2024

Copy link
Collaborator

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like especially the idea to clarify that recently merged Bitcoin Core commits will only be shipped in the next release

Comment on lines +112 to +150
*Note: the commits to Bitcoin Core mentioned below apply to its master
development branch and so those changes will likely not be released
until about six months after the release of the upcoming version 27.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'm a fan of this note, or mentioning specifically Bitcoin Core and not the others. How about permanently amending the introductory paragraph like this?

"These changes are expected to be included in future releases of the respective projects."

(Although this is a bit inaccurate since BIPs, BOLTs and BINANAs don't have releases.)

Copy link
Collaborator Author

@harding harding Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous discussion here: #395 (comment)

We haven't included this note for a while, but I saw some confusion on Twitter about whether recent merges would be included in the upcoming release, so I decided to re-instate it. I don't think the note generalizes, as only Bitcoin Core has this behavior; see this quote from the previous discussion:

AFAICT, Bitcoin Core is the only project we monitor that branches from master prior to a major release. (Indeed, I'm unable to think of any other free software project I've followed that does that.)

I'm happy to discuss further, but I suggest we include the note this week as we've included it many times before.

Comment on lines 134 to 137
currently used by [LN anchor outputs][topic anchor outputs]. V3
transaction relay is not currently enabled for mainnet and (as noted
above) this PR is merged into the development branch that is not
expected to be released for about six months.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of repeating the above note, how about just:

Suggested change
currently used by [LN anchor outputs][topic anchor outputs]. V3
transaction relay is not currently enabled for mainnet and (as noted
above) this PR is merged into the development branch that is not
expected to be released for about six months.
currently used by [LN anchor outputs][topic anchor outputs]. V3
transaction relay remains disabled on mainnet.

@harding
Copy link
Collaborator Author

harding commented Mar 20, 2024

Added lede, releases/RC, and topic links. Made all suggested edits (or left a reply), thanks everyone! Also reviewed the client/services section (thanks Mike!).

@bitschmidty bitschmidty force-pushed the 2024-03-20-newsletter branch from 06fe125 to 0c7417f Compare March 20, 2024 10:19
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK lede, topics (I made one small change), kindred replace by fee topic addition, and made sure all comments were resolved, squashed

@bitschmidty bitschmidty merged commit be49cdc into bitcoinops:master Mar 20, 2024
Copy link
Collaborator

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a review and forgot to submit it. 🤦

Comment on lines +19 to +21
signals_bip125: "true"
list: "true"
details: "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m wondering whether there should also be an update of the "date tested" or the receive side here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants