-
Notifications
You must be signed in to change notification settings - Fork 146
Founding sponsors on one row #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jamesob
commented
Jul 12, 2018

|
Ah oops - this broke /about. Fixing. |
|
Fixed /about: Also
|
|
Doesn't render well in Firefox and will probably break in Chrom(e|inium) if you play around with the responsive preview mode at various widths. At a super-quick look at the diff, I'd guess the problem is the removal of the nth-child clear rule, without which the layout engine tries to fit the content wherever it can rather than ensuring that all the previous floating content has been filled before filling new content. I can look into it more tomorrow if you'd like. (As for changing my title, that's fine. I have no strong preferences. If we ever meet in person sometime, you should ask me about my amusing story related to job titles.) |
|
Tested ACK 0f0c674 I rechecked after some sleep and discovered that somehow I hadn't checked out the latest branch head. Pulling the latest, it works for me. Forcing a min-height on the content seems slightly dangerous, as it'll be easy to make a change that later results in breaking something, e.g.: But fixing that problem correctly probably means redoing this with CSS flexbox or something. So this solution seems satisfactory for now since it does improve the ascetics IMO.
You guys are nuts, then. :-) It's a four hour round trip from NYC to here even with your own car. The sane thing to do is to wait until my list of things to do---and people to meet---in NYC grows to a length where I get unlazy enough to actually hop the bus to go there. |
|
Tested ACK 0f0c674. New layout is 😗 👌 |
Newsletters: add #21 (2018-11-13)



