Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Jan 6, 2020

No description provided.

@practicalswift
Copy link

Thanks for yet another great newsletter! Much appreciated!

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Harding. Nice short one to start the new year 👍

Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy 2020! @harding

Left a couple minor feedbacks.

Copy link
Collaborator

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year @harding and everyone. Looking forward to what we can do this year and decade for Bitcoin.

This newsletter looks good -- short but links to quite a lot of content. I verified the links at the bottom and the PRs in the notable changes section.


- **Encoded descriptors:** Chris Belcher [asked][belcher descriptors]
for feedback from the Bitcoin-Dev mailing list about base64 encoding
[output script descriptors][topic descriptors] so that they're easier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps "feedback... on encoding output script descriptors in base64" or similar might break up these five words a little for readability


- [C-Lightning #3351][] extends the `invoice` RPC with a new
`exposeprivatechannels` parameter that allows the user to request
the addition of route hints for private channels to a generated [BOLT11][]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/request the addition of/add|specify/ might be simpler to read

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the current phrasing because (if I understand the change correctly), the route hints requested aren't guaranteed to be added to the invoice---they're only added if the daemon considers the "channels to be usable" (e.g. they have incoming capacity).

advertise in the invoice, including both public and private channels.

- [LND #3647][] switches from using base64 to hex for the display of
binary data in the `listinvoices` RPC. This is a breaking API change for users of any
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps "binary data (payment hashes and preimages) in the listinvoices RPC."

[payment batching]: https://github.com/bitcoinops/scaling-book/blob/master/x.payment_batching/payment_batching.md
[belcher descriptors]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-December/017529.html
[news70 anchor]: /en/newsletters/2019/10/30/#ln-simplified-commitments
[taproot meeting]: http://www.erisian.com.au/meetbot/taproot-bip-review/2019/taproot-bip-review.2019-12-17-19.01.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We link to a line in the log a few sentences later, so I made this a link to the overview. I admit that this overview is particularly useful, but I think it's better than linking to the same file twice.

@jnewbery
Copy link
Contributor

jnewbery commented Jan 7, 2020

ACK 81a770a

@jnewbery
Copy link
Contributor

jnewbery commented Jan 7, 2020

I've added details and announcement for the next schnorr/taproot workshop here. @bitschmidty / @harding - can you verify that you're happy with the wording?

@harding
Copy link
Collaborator Author

harding commented Jan 7, 2020

Phrasing sounds good to me.

a transaction in order to be able to spend low-value UTXOs.

{% include linkers/issues.md issues="3647,3814,3351" %}
[Schnorr/Taproot workshops]: http://localhost:4000/en/schorr-taproot-workshop/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that there is no place like home, but should be changed before release? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks @practicalswift for catching that!


*None this week.*
- Bitcoin Optech is planning to hold a third Schnorr and Taproot
seminar workshop in London on 5th February 2020. This will cover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on 5th February 2020

Im not familiar with this phrasing. @jnewbery Maybe its just me?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to change it to February 5th 2020 for now, although MDY is a peculiarly American date format. Perhaps we should update the style guide to specify DMY or YMD (perhaps ISO 8601).

See https://en.wikipedia.org/wiki/Date_format_by_country for more details.

Copy link
Contributor

@bitschmidty bitschmidty Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I used newsletter # 78's wording as the tipping factor for me.

The Optech newsletter will return to its regular Wednesday publication schedule on January 8th.

Style guide entry sounds good either way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5th February 2020 is good; I vote for DMY or YMD / ISO8601 :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When spelling out at least the first three letters of the month, there shouldn't be any ambiguity, so I suggest letting it be author's choice like our spelling rules. If using just numbers and separators, my vote is also for ISO 8601.

Copy link

@practicalswift practicalswift Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for ISO 8601 :)

@bitschmidty bitschmidty force-pushed the 2020-01-08-newsletter branch from ff17723 to 42ed80e Compare January 8, 2020 12:42
@bitschmidty
Copy link
Contributor

Tweaked the date wording per #312 (comment) and squashed

@bitschmidty bitschmidty merged commit 6679b4c into bitcoinops:master Jan 8, 2020
@bitschmidty bitschmidty added the newsletters Publishing/translating/editing newsletters label Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

newsletters Publishing/translating/editing newsletters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants